Skip to content

Comments

fix: Increase timeout to 60 seconds#803

Merged
timgl merged 1 commit intomasterfrom
increase-timeout
Sep 20, 2023
Merged

fix: Increase timeout to 60 seconds#803
timgl merged 1 commit intomasterfrom
increase-timeout

Conversation

@timgl
Copy link
Collaborator

@timgl timgl commented Sep 20, 2023

Changes

We are killing requests after 10 seconds, causing retries. However, timeouts everywhere else in the system are 60 seconds. If the capture endpoint is slow, we just end up ddos'ing ourselves more

Checklist

@timgl timgl requested a review from fuziontech September 20, 2023 22:49
@timgl timgl added the bump patch Bump patch version when this PR gets merged label Sep 20, 2023
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 685 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 118 kB
dist/es.js 118 kB
dist/module.js 118 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timgl timgl merged commit 176e9cf into master Sep 20, 2023
@timgl timgl deleted the increase-timeout branch September 20, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump patch Bump patch version when this PR gets merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants